Added Travis job, mypy type checking #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Didn't annotate much, but I did add type annotations enough to make mypy not complain. I'll expand type annotations in the future as make sure to keep mypy happy.
Dorthu
force-pushed
the
travis-type-checking
branch
from
469ad26
to
875c62c
Compare
|
Looks like type hints in variables only works in python 3.6.. which makes me wonder if I want to restrict this library to only the newest of the new python (I'd already considered not supporting python2, but requiring 3.6+ seems like more of an ask) |
yoshizzle
approved these changes
Jan 5, 2021
commonism
referenced
this pull request
in commonism/openapi3
Jul 18, 2022
[pre-commit.ci] pre-commit autoupdate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't annotate much, but I did add type annotations enough to make mypy
not complain. I'll expand type annotations in the future as make sure
to keep mypy happy.